Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add presets #80

Draft
wants to merge 7 commits into
base: 61-persist-app-state
Choose a base branch
from
Draft

Add presets #80

wants to merge 7 commits into from

Conversation

sverhoeven
Copy link
Collaborator

@sverhoeven sverhoeven commented Nov 11, 2024

Refs #61

TODO

  • store preset as JSON files in apps/class-solid/public/presets
  • Start button shows avalable presets, and on click its loaded
  • On experiment knows if it was made from a preset, shown as star icon
    • preset persist on save
    • preset persist on dowload configuration
    • preset persist on dowload configuration & output
  • http://localhost:3000/?preset=/presets/death-valley.json loads the preset.
  • load from url with preset and partial configs
  • experiment from preset should have reference.config be partial towards preset. Aka when preset has theta_0: 500, then in reference form 500 should be placeholder.
  • permutation from experiment from preset should have its config partial towards reference config and preset. For example if preset has theta_0:500 and reference theta_0: 333 then placeholder in permutation form should be 333.
  • pruneConfig
    • (permuation, reference)
    • (permuation, reference, preset)
  • mergeConfigs(permuation, mergeConfigs(reference, preset))
  • use presets/defaults.json for defaults instead of defaults in packages/class/src/config.ts,
  • make app/presets/defaults.json symlink from package/src/defaults.json , make sure its included in npm publish config.json not on npm.js #76
  • makes preset required, with default to presets/defaults.json
  • make sure in diff, download and form partial configs are used, everywhere else use full config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant