Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

visually separate address 'box' on event page from rest of content #44

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

twagoo
Copy link
Member

@twagoo twagoo commented Sep 24, 2024

Example:


Before

image


After

image


@andmor-
Copy link
Member

andmor- commented Sep 25, 2024

Looks good. But since it is now scoped to events I think it should go to https://github.com/clarin-eric/clarin-drupal-bootstrap-theme/blob/1.5/scss/modules/events.scss

@twagoo
Copy link
Member Author

twagoo commented Sep 25, 2024

Looks good. But since it is now scoped to events I think it should go to https://github.com/clarin-eric/clarin-drupal-bootstrap-theme/blob/1.5/scss/modules/events.scss

Ok with me, however I believe that I did follow the example of other page type scoped field styles already defined in field.scss such as:

.node--type-k-centre-profile, .node--type-clarin-centre {
.field {
padding-bottom: 0.625rem;
p {
margin: 0;
}
}

and

.node--type-clarin-centre {
.field--name-field-location-coordinates .field__label {
display: block;
line-height: 0; /* Collapse the original line */
text-indent: -9999px;
&::after {
content: "Hosted by:";
display: block;
line-height: 3.126;
text-indent: 0;
}
}
.field--name-field-link-to-centre-registry, .field--name-field-location-coordinates {
a {
color: $blue;
text-decoration: underline;
}
}
}

@andmor- andmor- merged commit f7f0aa5 into 1.5 Sep 26, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants