Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example_csscal.c #362

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

LocutusOfBorg
Copy link

with gcc-14 this warning becomes a failure

90s /tmp/autopkgtest.g0L4Ek/autopkgtest_tmp/example_csscal.c: In function ‘main’:
90s /tmp/autopkgtest.g0L4Ek/autopkgtest_tmp/example_csscal.c:67:26: error: implicit declaration of function ‘abs’ [-Wimplicit-function-declaration]
90s 67 | int lenX = 1 + (N-1)*abs(incx);
90s | ^~~
90s /tmp/autopkgtest.g0L4Ek/autopkgtest_tmp/example_csscal.c:26:1: note: include ‘<stdlib.h>’ or provide a declaration of ‘abs’
90s 25 | #include <clBLAS.h>
90s +++ |+#include <stdlib.h>
90s 26 |
90s /tmp/autopkgtest.g0L4Ek/autopkgtest_tmp/example_csscal.c:89:5: warning: ‘clCreateCommandQueue’ is deprecated [-Wdeprecated-declarations]
90s 89 | queue = clCreateCommandQueue(ctx, device, 0, &err);
90s | ^~~~~

… declaration of abs function

with gcc-14 this warning becomes a failure

 90s /tmp/autopkgtest.g0L4Ek/autopkgtest_tmp/example_csscal.c: In function ‘main’:
 90s /tmp/autopkgtest.g0L4Ek/autopkgtest_tmp/example_csscal.c:67:26: error: implicit declaration of function ‘abs’ [-Wimplicit-function-declaration]
 90s    67 |     int lenX = 1 + (N-1)*abs(incx);
 90s       |                          ^~~
 90s /tmp/autopkgtest.g0L4Ek/autopkgtest_tmp/example_csscal.c:26:1: note: include ‘<stdlib.h>’ or provide a declaration of ‘abs’
 90s    25 | #include <clBLAS.h>
 90s   +++ |+#include <stdlib.h>
 90s    26 |
 90s /tmp/autopkgtest.g0L4Ek/autopkgtest_tmp/example_csscal.c:89:5: warning: ‘clCreateCommandQueue’ is deprecated [-Wdeprecated-declarations]
 90s    89 |     queue = clCreateCommandQueue(ctx, device, 0, &err);
 90s       |     ^~~~~
@anbe42
Copy link

anbe42 commented Aug 21, 2024

you should probably add debian/patches/no-implicit-declarations.patch to this PR (and set the title to e.g. "fix implicit declarations")

@LocutusOfBorg
Copy link
Author

ok added them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants