Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example_ctrsm.c #361

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LocutusOfBorg
Copy link

Fixup a failure due to

[ 16%] Building C object CMakeFiles/example_ctrsm.dir/example_ctrsm.c.o In file included from /usr/include/CL/cl.h:20,
from /usr/include/clBLAS.h:35,
from /tmp/example_ctrsm.c:25:
/usr/include/CL/cl_version.h:22:9: note: '#pragma message: cl_version.h: CL_TARGET_OPENCL_VERSION is not defined. Defaulting to 300 (OpenCL 3.0)'
22 | #pragma message("cl_version.h: CL_TARGET_OPENCL_VERSION is not defined. Defaulting to 300 (OpenCL 3.0)")
| ^~~~~~~
/tmp/example_ctrsm.c: In function 'main':
/tmp/example_ctrsm.c:95:48: error: passing argument 2 of 'clGetPlatformIDs' from incompatible pointer type [-Wincompatible-pointer-types]
95 | err = clGetPlatformIDs(sizeof( platform ), &platform, NULL);
| ^~~~~~~~~
| |
| struct _cl_platform_id ***
/usr/include/CL/cl.h:956:35: note: expected 'struct _cl_platform_id **' but argument is of type 'struct _cl_platform_id ***'
956 | cl_platform_id * platforms,
| ~~~~~~~~~~~~~~~~~^~~~~~~~~
/tmp/example_ctrsm.c:114:5: warning: 'clCreateCommandQueue' is deprecated [-Wdeprecated-declarations]
114 | queue = clCreateCommandQueue(ctx, device, 0, &err);
| ^~~~~
/usr/include/CL/cl.h:1914:1: note: declared here
1914 | clCreateCommandQueue(cl_context context,
| ^~~~~~~~~~~~~~~~~~~~

@anbe42
Copy link

anbe42 commented Aug 21, 2024

That patch makes platform an undefined pointer that gets written to ...

Maybe this is the intended behavior:

...
cl_platform_id platform;
...
err = clGetPlatformIDs(1, &platform, NULL);
...
err = clGetDeviceIDs(platform, CL_DEVICE_TYPE_CPU, 1, &device, NULL);
...
props[1] = (cl_context_properties)platform;
...

(completely untested)

@LocutusOfBorg
Copy link
Author

I don't honestly know, I just checked some examples and came out with something building. They are examples so I didn't care too much about sanity

@LocutusOfBorg
Copy link
Author

@anbe42
Copy link

anbe42 commented Aug 21, 2024

https://salsa.debian.org/science-team/clblas/-/blob/debian/master/debian/patches/fix-cl_platform_id-usage.patch?ref_type=heads

this brings cl_platform_id usage in example_ctrsm.c in line with the other clblas samples

Fixup a failure due to

[ 16%] Building C object CMakeFiles/example_ctrsm.dir/example_ctrsm.c.o
In file included from /usr/include/CL/cl.h:20,
                 from /usr/include/clBLAS.h:35,
                 from /tmp/example_ctrsm.c:25:
/usr/include/CL/cl_version.h:22:9: note: '#pragma message: cl_version.h: CL_TARGET_OPENCL_VERSION is not defined. Defaulting to 300 (OpenCL 3.0)'
   22 | #pragma message("cl_version.h: CL_TARGET_OPENCL_VERSION is not defined. Defaulting to 300 (OpenCL 3.0)")
      |         ^~~~~~~
/tmp/example_ctrsm.c: In function 'main':
/tmp/example_ctrsm.c:95:48: error: passing argument 2 of 'clGetPlatformIDs' from incompatible pointer type [-Wincompatible-pointer-types]
   95 |     err = clGetPlatformIDs(sizeof( platform ), &platform, NULL);
      |                                                ^~~~~~~~~
      |                                                |
      |                                                struct _cl_platform_id ***
/usr/include/CL/cl.h:956:35: note: expected 'struct _cl_platform_id **' but argument is of type 'struct _cl_platform_id ***'
  956 |                  cl_platform_id * platforms,
      |                  ~~~~~~~~~~~~~~~~~^~~~~~~~~
/tmp/example_ctrsm.c:114:5: warning: 'clCreateCommandQueue' is deprecated [-Wdeprecated-declarations]
  114 |     queue = clCreateCommandQueue(ctx, device, 0, &err);
      |     ^~~~~
/usr/include/CL/cl.h:1914:1: note: declared here
 1914 | clCreateCommandQueue(cl_context                     context,
      | ^~~~~~~~~~~~~~~~~~~~
@LocutusOfBorg
Copy link
Author

ok pushed thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants