Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update some parameter name to fit better prototype #414

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

StRigaud
Copy link
Member

No description provided.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 44.93308% with 288 lines in your changes missing coverage. Please review.

Project coverage is 46.08%. Comparing base (7f23184) to head (f4bfc8f).

Files with missing lines Patch % Lines
clic/src/tier1/binary_operations.cpp 48.78% 10 Missing and 32 partials ⚠️
clic/src/tier1/comparaison_operations.cpp 62.50% 0 Missing and 36 partials ⚠️
clic/src/tier4/parametrics_map.cpp 6.66% 24 Missing and 4 partials ⚠️
clic/src/tier3/statistics_of_labelled_pixels.cpp 20.00% 6 Missing and 6 partials ⚠️
clic/src/tier1/copy_slice.cpp 25.00% 0 Missing and 9 partials ⚠️
clic/src/statistics.cpp 12.50% 0 Missing and 7 partials ⚠️
clic/src/tier1/nonzero_maximum.cpp 33.33% 0 Missing and 6 partials ⚠️
clic/src/tier1/nonzero_minimum.cpp 33.33% 0 Missing and 6 partials ⚠️
clic/src/tier3/remove_labels.cpp 53.84% 1 Missing and 5 partials ⚠️
clic/src/tier1/replace_values.cpp 42.85% 1 Missing and 3 partials ⚠️
... and 96 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #414      +/-   ##
==========================================
- Coverage   46.09%   46.08%   -0.02%     
==========================================
  Files         199      181      -18     
  Lines        4022     4021       -1     
  Branches     1844     1844              
==========================================
- Hits         1854     1853       -1     
  Misses        762      762              
  Partials     1406     1406              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@StRigaud
Copy link
Member Author

update of parameters names:

  • if input expected is image -> input_image (default)
  • if input expected is label -> input_labels
  • if input expected is matrix -> input_matrix
  • if input expected is coordinates -> input_coordinates

related to the discution here:

not yet fully applied because this would also change some parameter name that were updated for I2K and compatibility with assistant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants