Devel #42
Open
Devel #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e missing keys in x dont cause the plot to fail
…ession for the fit function This closes #39
…nd meta are now members of the GUI The motivation was to have all relevant update layout calls close to each other and simplify the call structure. Also the meta argument which was passed around is now more uniform (i.e., meta_values is a list and just meta a dict)
Makes use of mypy
This simplifies overriding default content
Html class design
…e missing keys in x dont cause the plot to fail
…ession for the fit function This closes #39
…nd meta are now members of the GUI The motivation was to have all relevant update layout calls close to each other and simplify the call structure. Also the meta argument which was passed around is now more uniform (i.e., meta_values is a list and just meta a dict)
Makes use of mypy
This simplifies overriding default content
Codecov Report
@@ Coverage Diff @@
## master #42 +/- ##
==========================================
+ Coverage 79.85% 80.38% +0.53%
==========================================
Files 17 19 +2
Lines 541 617 +76
==========================================
+ Hits 432 496 +64
- Misses 109 121 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor adjustments, more linting and doc updates as well as the more significant update for class based content elements #41