Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(extension-chrome): use design system to simplify code #195

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

IronLu233
Copy link
Contributor

@IronLu233 IronLu233 commented Apr 11, 2023

What Changed

https://www.figma.com/file/x49RWTMPXmN5UgbaCAkraN/wallet?node-id=982-1329&t=qvCEVarGM3jZN3sn-0

implement the UI on HIFI(updated)

Motivation

for making the UI more clear.

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

🐤 Download canary assets:

nexus--canary.195.4697587484.zip

📦 Published PR as canary version: 0.0.14--canary.195.4697587484.0

✨ Test out this PR locally via:

npm install @nexus-wallet/[email protected]
npm install @nexus-wallet/[email protected]
npm install @nexus-wallet/[email protected]
# or 
yarn add @nexus-wallet/[email protected]
yarn add @nexus-wallet/[email protected]
yarn add @nexus-wallet/[email protected]

@IronLu233 IronLu233 self-assigned this Apr 11, 2023
@IronLu233 IronLu233 marked this pull request as draft April 11, 2023 09:39
@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #195 (4c76c53) into main (c122156) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #195   +/-   ##
=======================================
  Coverage   86.12%   86.12%           
=======================================
  Files          45       45           
  Lines         872      872           
  Branches      114      114           
=======================================
  Hits          751      751           
  Misses         20       20           
  Partials      101      101           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@IronLu233 IronLu233 changed the title Design system feat(extension-chrome): use design system to simplify code Apr 11, 2023
@IronLu233 IronLu233 marked this pull request as ready for review April 11, 2023 11:39
@IronLu233 IronLu233 mentioned this pull request Apr 11, 2023
3 tasks
},
}));

export const Input = defineMultiStyleConfig({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Input a multipart component?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@homura homura added the minor Increment the minor version when merged label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants