Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rpc): added null and boolean to batch rpc #736

Merged
merged 3 commits into from
Aug 2, 2024
Merged

Conversation

homura
Copy link
Collaborator

@homura homura commented Aug 2, 2024

Description

This PR added boolean and null to batch rpc client

@homura homura requested a review from Keith-CY August 2, 2024 03:55
Copy link

vercel bot commented Aug 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
lumos-website ✅ Ready (Inspect) Visit Preview Aug 2, 2024 4:10am

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.81%. Comparing base (3763977) to head (425f67a).

Files Patch % Lines
packages/rpc/src/index.ts 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #736      +/-   ##
===========================================
- Coverage    87.24%   85.81%   -1.43%     
===========================================
  Files          133      133              
  Lines        25373    25378       +5     
  Branches      2751     2673      -78     
===========================================
- Hits         22136    21779     -357     
- Misses        3197     3559     +362     
  Partials        40       40              
Files Coverage Δ
packages/rpc/src/method.ts 90.81% <100.00%> (-2.74%) ⬇️
packages/rpc/src/index.ts 48.02% <50.00%> (-28.25%) ⬇️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3763977...425f67a. Read the comment docs.

.changeset/khaki-gorillas-sell.md Outdated Show resolved Hide resolved
Co-authored-by: Chen Yu <[email protected]>
Signed-off-by: homura <[email protected]>
@homura homura merged commit 3cf82d9 into develop Aug 2, 2024
7 checks passed
@github-actions github-actions bot mentioned this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants