-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add create react app example #714
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## browser #714 +/- ##
===========================================
+ Coverage 84.76% 87.11% +2.34%
===========================================
Files 132 132
Lines 25249 25249
Branches 2594 2736 +142
===========================================
+ Hits 21403 21996 +593
+ Misses 3810 3212 -598
- Partials 36 41 +5
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
I couldn't find a use case related to Lumos in this example. Could you please import Lumos to the |
Yes. I already did it in |
The Lumos without node modules have not been published yet. How can you confirm that Lumos works fine with standalone projects created by Vite? |
So to simulate a developer's behavior, we probably need to publish a preview/dev version, and setup 3 (vite, nextjs, create-react-app) standalone proejcts, install Lumos and test it to make sure everything works. |
I think |
I try Verdaccio but can't add user. So I published all packages with a different name
and created 3 standalone projects
installed They all work well. |
Verified with Vite by installing |
Description
This PR
next.config.mjs
in nextjs examplecreate-react-app
example that use Lumos in browsers without extra configs.Why there's no Vite example ?
I tried to create a vite example in
lumos/examples
but it/vite/rollup didn't convert commonjs modules to es6.So when I import and use Lumos there's a
exports is not defined
error, and I didn't find any solution yet.There's no such errors when use vite with standalone projects (not in monorepo)
We can publish a preivew version of this branch, e.g
0.30.0.preview
and create standalone projects (vite, nextjs, create-react-app) to install the preview version and test the browser compatibility related changes.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Unit Tests