Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove peerDependency of toolkit #560

Merged
merged 9 commits into from
Oct 13, 2023

Conversation

zhangyouxin
Copy link
Contributor

Description

This PR removes peerDependency of toolkit package

Type of change

  • Refactor (non-breaking change)

How Has This Been Tested?

  • Smoke test to make sure base Normalizers using normalizeHexNumber works

@vercel
Copy link

vercel bot commented Oct 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
lumos-website ✅ Ready (Inspect) Visit Preview Oct 13, 2023 6:00am

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #560 (5ff0e0b) into develop (ed5dc56) will increase coverage by 0.31%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #560      +/-   ##
===========================================
+ Coverage    86.65%   86.96%   +0.31%     
===========================================
  Files          115      115              
  Lines        23102    23102              
  Branches      2333     2358      +25     
===========================================
+ Hits         20019    20091      +72     
+ Misses        3040     2967      -73     
- Partials        43       44       +1     
Files Coverage Δ
packages/toolkit/src/normalizers.js 38.96% <100.00%> (+12.66%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed5dc56...5ff0e0b. Read the comment docs.

@homura
Copy link
Collaborator

homura commented Oct 11, 2023

We don't need to bump the version manually, can you follow the For Contributor section to add the changeset?

@homura homura merged commit db34aef into ckb-js:develop Oct 13, 2023
5 checks passed
@github-actions github-actions bot mentioned this pull request Oct 13, 2023
@github-actions github-actions bot mentioned this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants