refactor(common-scripts): simplify global provider check

ckb-js · Jun 24, 2024 · 4b0b31f · 4b0b31f
1 parent ac29338
commit 4b0b31f
Showing 1 changed file with 4 additions and 13 deletions.
diff --git a/packages/common-scripts/src/omnilock-ethereum-displaying.ts b/packages/common-scripts/src/omnilock-ethereum-displaying.ts
@@ -17,23 +17,14 @@ export async function signMessage(
   digest: BytesLike,
   provider?: Provider
 ): Promise<string> {
-  const internal: Provider = (() => {
-    if (provider) return provider;
-
-    /* c8 ignore start */
-    if (
-      typeof window !== "undefined" &&
-      "ethereum" in window &&
-      window.ethereum
-    ) {
-      return window.ethereum as Provider;
-    }
+  const internal: Provider | undefined =
+    provider ?? (globalThis as { ethereum?: Provider }).ethereum;
 
+  if (!internal) {
     throw new Error(
       "No provider found, make sure you have installed MetaMask or the other EIP1193 compatible wallet"
     );
-    /* c8 ignore stop */
-  })();
+  }
 
   const sig = await internal.request({
     method: "personal_sign",