Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove *.override scripts in /setup #150

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,9 @@ The Docker image config files used to build your CKAN project are located in the
* CKAN is started running this: `/usr/bin/ckan -c /srv/app/ckan.ini run -H 0.0.0.0`.
* Make sure to add the local plugins to the `CKAN__PLUGINS` env var in the `.env` file.

* Any custom changes to the scripts run during container start up can be made to scripts in the `setup/` directory. For instance if you wanted to change the port on which CKAN runs you would need to make changes to the Docker Compose yaml file, and the `start_ckan.sh.override` file. Then you would need to add the following line to the Dockerfile ie: `COPY setup/start_ckan.sh.override ${APP_DIR}/start_ckan.sh`. The `start_ckan.sh` file in the locally built image would override the `start_ckan.sh` file included in the base image
### Overriding the setup/* files derived from the CKAN base image

Any deviations or custom changes to the scripts run during container startup can be made by overriding those scripts in the `ckan/setup/` directory. For instance if you wanted to change the port on which CKAN runs you would need to make changes to the Docker Compose yaml file, plus the `start_ckan.sh` file. The `start_ckan.sh` file in the locally built image will override the `start_ckan.sh` file included in the base image. You would also need to include a `COPY setup/start_ckan.sh ${APP_DIR}` command in the relevant Dockerfile to copy the (override) script to the newly-built local image

### Extending the base images

Expand Down
5 changes: 5 additions & 0 deletions ckan/setup/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Create scripts in this folder to override the scripts inherited from the CKAN base images.
These scripts would most likely be one of:
1. `start_ckan.sh`
2. `start_ckan_development.sh`
3. `prerun.py`
212 changes: 0 additions & 212 deletions ckan/setup/prerun.py.override

This file was deleted.

57 changes: 0 additions & 57 deletions ckan/setup/start_ckan.sh.override

This file was deleted.

99 changes: 0 additions & 99 deletions ckan/setup/start_ckan_development.sh.override

This file was deleted.

Loading