Google module is broken

[nilicule]

Google module is not returning results. Fixed.

[cjones]

heya, just saw this. can you explain better what needed fixing? this seems to have just disabled the addressing requirement for this module (which requires you address the bot, in other words say, "botname: google foo" instead of just "google foo"). I'm open for making this a config option if you prefer it that way, but turning it off completely isn't gonna work as a general approach because a number of people do not want the bot triggering on accident, especially in work irc situations. Also worth pointing out, I think, that all modules that output a response to chat require addressing in the same way (save but a few exceptional cases like jinx.py and factoids.py, both of which come with a "spaminess is implied" factor in a way google.py definitely doesn't).

sorry if missing something beyond that, you'll have to elaborate on how it's broken if that wasn't the salient change.

[nilicule]

On Tue, Feb 18, 2014 at 12:44 AM, Chris Jones [email protected]:

heya, just saw this. can you explain better what needed fixing? this seems
to have just disabled the addressing requirement for this module (which
requires you address the bot, in other words say, "botname: google foo"
instead of just "google foo"). I'm open for making this a config option if
you prefer it that way, but turning it off completely isn't gonna work as a
general approach because a number of people do not want the bot triggering
on accident, especially in work irc situations.

Ideally I'd have this as a config option. One of the channels I run this
bot in has the bot set up to react without being addressed and this is the
one feature that doesn't seem to trigger without the patch I supplied.

Having this as a config option would allow for both situations to work, so
that would be perfect indeed.

Also worth pointing out, I think, that all modules that output a response
to chat require addressing in the same way (save but a few exceptional
cases like jinx.py and factoids.py, both of which come with a "spaminess is
implied" factor in a way google.py definitely doesn't).

Correct, didn't notice that before because those modules aren't enabled in
my case.

regards,
Remco

[cjones]

Sorry for the late reply, very busy with a startup these days, and all the email notifications go to my spam-overrun gmail.

So, I think I'm still missing something here. Can you elaborate a bit on what you did to avoid the addressing requirement with other modules? Just looking real quick at the google.py module on its own, I don't think it's different than any other module with require_addressing set. I actually thought I had a config option to turn off that requirement entirely, but I don't see it anywhere in my own config, so I maybe just meant to do it and never did, or... something. I have some ideas for how this can be done easily, but feel like I possibly don't have all the facts, since afaik every module except for a few special ones behave the same way as the google one. Is it just that you only use a few modules?

(You probably know this, but on the off- chance you don't: you can set easier-to-type aliases for the nick which count as addressing. Most people use ! or . -- or both, even -- so it is just "!google " to trigger, for example, a google search).

(Which leads me to a thought: You might try putting the empty string as an alias and see what that does..I honestly don't know, but feel like it should have the effect of disabling aliasing requirement, logically, by matching every line. If it doesn't work that way, it's likely something like a "if alias: do_alias_handling" check that can be removed, as long as it treated an empty array of aliases as "no aliases" still.