Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed functional slice breakdown #4

Merged
merged 5 commits into from
May 19, 2023
Merged

Proposed functional slice breakdown #4

merged 5 commits into from
May 19, 2023

Conversation

vpa1977
Copy link

@vpa1977 vpa1977 commented May 15, 2023

Split slices into

  • core : minimal set of files required for running java 8
  • security: required for encryption and tls tasks
  • devel: debugging, profiling and instrumentation
  • awt: graphics tasks
  • tools: tools laucher

This allows to build chiselled jre based on the functions required:

RUN mkdir -p /rootfs \
      && chisel cut --release /opt/chisel-releases --root /rootfs \
     openjdk-8-jre-headless_core  \
     openjdk-8-jre-headless_security  \
    base-files_bin \

will build something that can curl github over https.

RUN mkdir -p /rootfs \
      && chisel cut --release /opt/chisel-releases --root /rootfs \
     openjdk-8-jre-headless_core  \
     openjdk-8-jre-headless_security  \
     openjdk-8-jre-headless_management \
    base-files_bin \

host a minecraft server

RUN mkdir -p /rootfs \
      && chisel cut --release /opt/chisel-releases --root /rootfs \
     openjdk-8-jre-headless_core  \
     openjdk-8-jre-headless_security  \
     openjdk-8-jre-headless_awt \
    base-files_bin \

manipulate pdf files

etc.

vpa1977 added 2 commits May 16, 2023 09:48
Split slices into
- core : basic minimal jre
- security: required for encryption and tls tasks
- devel: debugging, profiling and instrumentation
- awt: graphics tasks
- tools: tools laucher
@vpa1977
Copy link
Author

vpa1977 commented May 16, 2023

  • lets split devel slice into jfr / debugging|profiling
  • split out ext slice from core
  • comment on core that we should not take away dependencies since rt.jar is there

Copy link
Owner

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vpa1977 ! This is looking great. I confirm that this is the right approach (slicing with basis on the functional unit).

I've left a few comments and suggestions for changes, but after that, we should be good to merge it ;)

slices/openjdk-8-jre-headless.yaml Outdated Show resolved Hide resolved
slices/openjdk-8-jre-headless.yaml Show resolved Hide resolved
slices/openjdk-8-jre-headless.yaml Outdated Show resolved Hide resolved
slices/openjdk-8-jre-headless.yaml Outdated Show resolved Hide resolved
slices/openjdk-8-jre-headless.yaml Outdated Show resolved Hide resolved
slices/openjdk-8-jre-headless.yaml Outdated Show resolved Hide resolved
slices/openjdk-8-jre-headless.yaml Show resolved Hide resolved
slices/openjdk-8-jre-headless.yaml Outdated Show resolved Hide resolved
slices/openjdk-8-jre-headless.yaml Outdated Show resolved Hide resolved
slices/openjdk-8-jre-headless.yaml Outdated Show resolved Hide resolved
@cjdcordeiro cjdcordeiro self-assigned this May 17, 2023
@vpa1977
Copy link
Author

vpa1977 commented May 18, 2023

I've added draft rockcrafters/chiselled-jre#107 for the chiselled jre so that we could validate this pull request against chiselled jre repo

@vpa1977 vpa1977 requested a review from cjdcordeiro May 18, 2023 20:27
@cjdcordeiro
Copy link
Owner

thanks for this @vpa1977

i'll merge it and do some changes.

@cjdcordeiro cjdcordeiro merged commit 3225a71 into cjdcordeiro:jre8-jammy-slices May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants