add file for parameterized api calls #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffaristocrat
suggested changes
Jan 18, 2019
| credential_id: cred2 | ||
| remote_host_id: db2 | ||
| syncs: | ||
| - source: |
There was a problem hiding this comment.
this section needs to be indented
There was a problem hiding this comment.
Huh, gave it whirl - it's valid yaml.
Stylistically I prefer the indentation as it makes it clear the list is a child of syncs.
mattyb
reviewed
May 10, 2019
| sync_type: Dbsync | ||
| is_outbound: False | ||
| source: | ||
| credential_id: cred1 |
There was a problem hiding this comment.
@mmatkinson can we make these numbers? credential_id and remote_host_id don't accept strings.
There was a problem hiding this comment.
is there a way to force them to be numbers in the yml?
mattyb
requested changes
May 14, 2019
| sync_type: Dbsync | ||
| is_outbound: False | ||
| source: | ||
| credential_id: cred1 |
There was a problem hiding this comment.
Suggested change
| credential_id: cred1 | |
| credential_id: 101 |
| is_outbound: False | ||
| source: | ||
| credential_id: cred1 | ||
| remote_host_id: db1 |
There was a problem hiding this comment.
Suggested change
| remote_host_id: db1 | |
| remote_host_id: 201 |
| credential_id: cred1 | ||
| remote_host_id: db1 | ||
| destination: | ||
| credential_id: cred2 |
There was a problem hiding this comment.
Suggested change
| credential_id: cred2 | |
| credential_id: 102 |
| remote_host_id: db1 | ||
| destination: | ||
| credential_id: cred2 | ||
| remote_host_id: db2 |
There was a problem hiding this comment.
Suggested change
| remote_host_id: db2 | |
| remote_host_id: 202 |
|
We've changed the default branch to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.