Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for compound CRS as CURIEs #193

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

balazsdukai
Copy link
Member

Allow compound CRS in metadata.referenceSystem the form of CURIEs, in addition to the current URI syntax.

For example:

"referenceSystem": [
    "[EPSG:4326]",
    "[EPSG:3855]"
  ]

The schema allows any UPPER/lowercase letter or digit as identifier, and any UPPER/lowercase letter as authority.

However, this change breaks backwards compatibility, so it would require a new major version.

If we decide to merge this PR, the specs need to be updated too.

Fixes #181

@balazsdukai balazsdukai requested a review from hugoledoux April 9, 2024 08:25
@hugoledoux
Copy link
Member

This would break v2.0 as not backwards compatible... One way to fix this would be to add a new property "referenceSystem3D", but I am not sure if compound have only 2 components max. You know?

@balazsdukai
Copy link
Member Author

My interpretation of the specs is that there are only two.

But I would rather keep this for a next major version than having a "referenceSystem3D" tbh. I think there should be one, and only one place to declare sth, and two referenceSystem-s would break that.

@balazsdukai balazsdukai added v3 CityJSON version 3 and removed enhancement labels Oct 8, 2024
@balazsdukai balazsdukai marked this pull request as ready for review December 17, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 CityJSON version 3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support for compound-CRS?
2 participants