Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"year built" has comma in pop-up #18

Open
almccon opened this issue Dec 13, 2016 · 1 comment
Open

"year built" has comma in pop-up #18

almccon opened this issue Dec 13, 2016 · 1 comment
Assignees
@almccon

Comments

@almccon
Copy link
Member

almccon commented Dec 13, 2016

Should not have the default number formatting. Should be "1998" not "1,998".

This is a bug in the other cityenergy sites, too.

screen shot 2016-12-13 at 13 dec 12 23 48
@almccon
Copy link
Member Author

almccon commented Dec 13, 2016

Solution: make sure the relevant column is a "string" type in CARTO, not a "number". Then the pop-up will automatically format it correctly. No code changes needed.

screen shot 2016-12-13 at 13 dec 2 23 13
screen shot 2016-12-13 at 13 dec 2 22 31

@almccon almccon mentioned this issue Dec 13, 2016
Closed
@almccon almccon mentioned this issue Jan 7, 2017
Open
almccon added a commit that referenced this issue Jan 9, 2017
@almccon
fix comma in popup #18
a11e35c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@almccon almccon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sconnelley @almccon