Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Year build color ramp on dots failing #32

Open
emilyhobson opened this issue Jan 5, 2017 · 2 comments
Open

Year build color ramp on dots failing #32

emilyhobson opened this issue Jan 5, 2017 · 2 comments
Assignees

Comments

@emilyhobson
Copy link

Year build color not showing up on dots

image

@almccon
Copy link
Member

almccon commented Jan 7, 2017

I think requiring the year field to be a string (#18) is what caused this.

Interestingly, the histogram seems to parse the strings back into numbers, but the map does not.

If I switch the database field back into a number, then the map works:

screen shot 2017-01-06 at 6 jan 4 10 52

And note that in some places we correctly format the year, but in other places (like the average year) we incorrectly show a comma.

So I think the correct approach is just to fix the formatting of the numbers wherever they are wrong, and continue treating "year" as a number in the database.

@almccon
Copy link
Member

almccon commented Jan 7, 2017

See also #25 for the average year comma bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants