Feature/unknown 404

[thanaParis]

From the OCPP 2.0.1 specification:

• If the CSMS does not recognize the Charging Station identifier in the URL path, it SHOULD send an HTTP response with status 404 and abort the WebSocket connection as described in [RFC6455].

Citrine previously always gave a 401, this pr gives a 404 when the charger is unknown and 500 when the server itself has an error.

[elliot-sabitov]

isnt the left and the right of the || operator, always going to fire? I am seeing that error?.terminateConnection returns void, doesnt that mean that the right side will fire unintentionally?

[elliot-sabitov]

would it be cleaner to move:

terminateConnection(socket: Duplex): void {
        socket.write('HTTP/1.1 401 Unauthorized\r\n');
        socket.write(
            'WWW-Authenticate: Basic realm="Access to the WebSocket", charset="UTF-8"\r\n',
        );
        socket.write('\r\n');
        socket.end();
        socket.destroy();
    }

as a helper method along with this._terminateConnectionInternalError and instead maybe do something like:

if (error instanceOf UpgradeAuthenticationError) {
  this.terminateAuthenticationError();
} else {
  this.terminateConnectionError();
}

the two functions are more or less the same and it feels a bit odd that the socket handling is in the error

[elliot-sabitov]

ah I see, there is also UpgradeUnknownError, but maybe there can be a handle helper function here like:

terminateConnectionHelper(socket: Duplex, str1 = 'HTTP/1.1 500 Internal Server Error', str2 = ''): void {
        socket.write('${str1}\r\n');
        socket.write(
            '${str2}\r\n',
        );
        socket.write('\r\n');
        socket.end();
        socket.destroy();
    }

and then just:

if (error instanceOf UpgradeAuthenticationError) {
  this.terminateConnectionHelper(socket, 'HTTP/1.1 401 Unauthorized', ''WWW-Authenticate: Basic realm="Access to the WebSocket", charset="UTF-8"');
} else if (error instanceOf UpgradeUnknownError) {
  this.terminateConnectionHelper(socket, 'HTTP/1.1 404 Not Found');
} else {
 this.terminateConnectionHelper(socket);
}