Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AttachCamToPedBone.md #914

Closed
wants to merge 2 commits into from

Conversation

niekschoemaker
Copy link
Contributor

@niekschoemaker niekschoemaker commented Sep 3, 2023

As can be seen in GTA source code:

			Var0 = { PED::GET_PED_BONE_COORDS(PLAYER::PLAYER_PED_ID(), 31086, 0f, -0.25f, 0f) };
			func_116(&Local_325, Var0, ENTITY::GET_ENTITY_ROTATION(PLAYER::PLAYER_PED_ID(), 2), 50f, Local_325.f_20, Local_325.f_21, 3, 1101004800, 0, 0, -1082130432, 0);
			CAM::ATTACH_CAM_TO_PED_BONE(Local_325.f_0, PLAYER::PLAYER_PED_ID(), 31086, 0f, -0.25f, 0f, true);

The bone parameter here is a boneId and not a boneIndex.

@AvarianKnight
Copy link
Collaborator

You forgot to change the parameter name in the function declaration, which is why the CI failed.

CAM/AttachCamToPedBone.md Show resolved Hide resolved
@4mmonium
Copy link
Contributor

4mmonium commented Nov 8, 2023

31086

Actually, I now realize. That number is SKEL_Head = 0x796E in hex, which is a bone index, it's defined here.

This PR has been effectively superseded by this commit and 4089 in hex is actually SKEL_L_Finger01 = 0xFF9 as it reads there.

Thank you for your contribution. I may need to close this PR since this has already been updated, but the effort is appreciated.

@4mmonium 4mmonium closed this Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants