feat(docs/natives/RENDER_SCRIPT_CAMS): Renamed and explained the 4th … #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PsychoShock
suggested changes
Jul 28, 2024
CAM/RenderScriptCams.md
Outdated
Comment on lines
13
to
18
| ## Parameters | ||
| * **render**: Whether to render the cams or not. | ||
| * **ease **: If true it will make a smooth transition between the current camera and the new rendered camera. | ||
| * **easeTime **: The in milliseconds for the transition to happen. | ||
| * **easeCoordsAnim**: If false it will only do the smooth transition to the rotation and the coords will be set instantly. | ||
| * **p4**: Doesn't seem to change anything. |
There was a problem hiding this comment.
Param section should go after the added param.
CAM/RenderScriptCams.md
Outdated
Comment on lines
13
to
18
| ## Parameters | ||
| * **render**: Whether to render the cams or not. | ||
| * **ease **: If true it will make a smooth transition between the current camera and the new rendered camera. | ||
| * **easeTime **: The in milliseconds for the transition to happen. | ||
| * **easeCoordsAnim**: If false it will only do the smooth transition to the rotation and the coords will be set instantly. | ||
| * **p4**: Doesn't seem to change anything. |
There was a problem hiding this comment.
Try to use something more general and add what value is used by default in decompiled scripts.
There was a problem hiding this comment.
It's just that, if ease is true this param will change the behaviour in the transition
colistro123
suggested changes
Jul 29, 2024
CAM/RenderScriptCams.md
Outdated
| @@ -8,22 +8,15 @@ ns: CAM | |||
| void RENDER_SCRIPT_CAMS(BOOL render, BOOL ease, int easeTime, BOOL p3, BOOL p4); | |||
There was a problem hiding this comment.
Where's easeCoordsAnim, which is p3? This is why the checks are failing. The parameter section has to match these.
There was a problem hiding this comment.
Oh, now I see thanks
AvarianKnight
requested changes
Jul 29, 2024
Co-authored-by: Dillon Skaggs <[email protected]>
Co-authored-by: Dillon Skaggs <[email protected]>
Co-authored-by: Dillon Skaggs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.