Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sign Messages without Exported Private Keys (leveraging WalletConnect/Reown SDK) #2

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

josiah-buxton
Copy link
Contributor

@josiah-buxton josiah-buxton commented Dec 6, 2024

Summary

Adds functionality to sign messages using WalletConnect/Reown SDK instead of exported private keys. Both are supported and QR code will be displayed in CLI if private key not provided with an address in the SIGNER_ADDRESSES env var array. Wallet mobile apps can scan QR code to create a pipe to sign messages for MSCA wallet token transfer.

Testing

Tested locally on polygon-amoy.

Screenshot 2024-12-04 at 4 15 56 PM

Copy link

@yifan-circle yifan-circle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@josiah-buxton josiah-buxton merged commit b319125 into circlefin:master Dec 6, 2024
2 checks passed
@josiah-buxton josiah-buxton deleted the v1.0.0 branch December 6, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants