Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added license and other metadata #62

Merged
merged 4 commits into from
Nov 15, 2024
Merged

added license and other metadata #62

merged 4 commits into from
Nov 15, 2024

Conversation

stroblme
Copy link
Member

@stroblme stroblme commented Nov 14, 2024

This PR resolves #59 by adding metadata as described in the poetry docs (same as PEP standard, except for the section (tool.poetry vs project)).
The latter was resolved recently (python-poetry/poetry#9135 (comment)), but it's not in the official docs yet, so might be a bit early to adopt.

Signed-off-by: Melvin Strobl <[email protected]>
@stroblme stroblme marked this pull request as ready for review November 14, 2024 07:09
@stroblme
Copy link
Member Author

maybe we could also bump the allowed python version.. currently we're quite limited in that regard.
Could you check that with 3.13 @majafranz ?

Signed-off-by: Melvin Strobl <[email protected]>
@pep8speaks
Copy link

Hello @stroblme! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 202:89: E501 line too long (99 > 88 characters)

Copy link
Collaborator

@majafranz majafranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@majafranz
Copy link
Collaborator

maybe we could also bump the allowed python version.. currently we're quite limited in that regard.
Could you check that with 3.13 @majafranz ?

3.13 is not supported by pennylane-lightning rn. Suggest to update to 3.12 instead.

Signed-off-by: Melvin Strobl <[email protected]>
@stroblme stroblme merged commit 27f22b2 into main Nov 15, 2024
4 checks passed
@stroblme stroblme deleted the license branch November 15, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Check why licensecheck is failing
3 participants