Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sampling #56

Merged
merged 18 commits into from
Oct 8, 2024
Merged

Sampling #56

merged 18 commits into from
Oct 8, 2024

Conversation

stroblme
Copy link
Member

@stroblme stroblme commented Oct 7, 2024

This PR resolves #52 by

  • introducing initialization_domain parameter in the model initialization and parameter initialization
  • switching to rng instead of seed in the parameter initialization because this allows repetitive calls to this function
  • adding a repeat parameter in the parameter initialization to allow sampling sets of parameters
  • minor adjustments of the tests due to the now different init range
  • test for the re-initialization
  • input domain parameter for sampling state-fidelities (is now a required parameter)

Melvin Strobl added 11 commits October 7, 2024 10:26
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
@pep8speaks
Copy link

pep8speaks commented Oct 7, 2024

Hello @stroblme! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 56:70: E203 whitespace before ':'

Comment last updated at 2024-10-08 06:37:06 UTC

Melvin Strobl added 3 commits October 7, 2024 15:09
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Melvin Strobl and others added 4 commits October 7, 2024 15:32
Copy link
Collaborator

@majafranz majafranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Looks good to me :)

@stroblme stroblme merged commit 15f2dca into main Oct 8, 2024
4 checks passed
@stroblme stroblme deleted the sampling branch October 8, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Streamline sampling domain for parameters
3 participants