feat: Add location addresses data from Korea #445

[GitKimUser]

• Update location.cpp
• Update location_data.h
• Update location_test.cpp

[cieslarmichal]

why did you add some submodule? please remove

[GitKimUser]

why did you add some submodule? please remove

do I have to remove all of the submodule?

[cieslarmichal]

Looks like you added faker-cxx as submodule, look in PR changes

[GitKimUser]

Looks like you added faker-cxx as submodule, look in PR changes

I think that ./faker-cxx/faker-cxx is the directory that makes problem.. right??

[cieslarmichal]

Yes try to delete it from changes

[cieslarmichal]

also resolve conflicts

[GitKimUser]

also resolve conflicts

I copied the codes and put them in as they were to resolve the conflict, but I checked and found out that this was not the right method. So, when I ran git merge origin/merge to get the latest source, the message 'are ready up to date' was already displayed, so I couldn't get the updated codes while I was working on it. Do you know how to get the latest source, update it, and commit again to avoid conflict in this situation?

[cieslarmichal]

I would try this: https://stackoverflow.com/questions/65215051/how-to-pull-the-changes-from-main-branch-to-forked-branch - it should work, if not join our discord channel and we will help you

[GitKimUser]

I would try this: https://stackoverflow.com/questions/65215051/how-to-pull-the-changes-from-main-branch-to-forked-branch - it should work, if not join our discord channel and we will help you

I saw the contents of the stackoverflow you provided, tried it, and changed it again. I made several commitments, but I forgot to push, so I pushed all at once. I wonder if the conflict has been resolved about the change. If it hasn't been resolved, do I have to use git push origin feature/kim as the name of the branch??

[cieslarmichal]

test for koea fails: LocationTest.shouldGenerateKoreaStreet
also run clang format

[GitKimUser]

test for koea fails: LocationTest.shouldGenerateKoreaStreet also run clang format

I've tried building and ctest without any code modification at the moment, but it passed with the screenshot. Regarding this test, is it irrelevant to the error above? Or was there a version update or correction for the ctest?

[cieslarmichal]

I have merged main branch into yours here, you can try fetching it and trying to run tests

[GitKimUser]

I have merged main branch into yours here, you can try fetching it and trying to run tests

You mean the process of this screenshot, right? If so, when I ran the ctest again, it said that it didn't fail.