Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List item redesign #52

Open
wants to merge 59 commits into
base: master
Choose a base branch
from

Conversation

EWhite613
Copy link
Contributor

@EWhite613 EWhite613 commented Aug 16, 2016

minor

Requires #51

Changelog

  • Add expand/collapse of items
  • Item has four columns.
    • Block replaced with item component. Takes four columns (firstColumn is optional)
  • primaryId specifies the model identifier ( can also use a component, gets passed the model)
  • secondaryId specifies the model secondary identifier ( can also use a component, gets passed the model)
  • Each item has an SVG component, that is passed the model and displays in the first column.
  • In the expanded view each component renders its {{#if isExpanded}} .. {{/if}} block
    Example template:
{{frost-list
class='frost-flex-1'
records=listItems
selections=selectedItems
item=(component 'frost-list-item-binding' primaryId='id' secondaryId=(component 'secondary-component') svg=(component 'list-item-svg') detailLevel=activeDetailLevel firstColumn=(component 'first-column') secondColumn=(component 'column-two') thirdColumn=(component 'column-three') fourthColumn=(component 'column-four'))
onSelect=(action 'selected')
}}

@coveralls
Copy link

coveralls commented Aug 16, 2016

Coverage Status

Changes Unknown when pulling 57fad80 on EWhite613:list-item-redesign into * on ciena-frost:master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 415f91a on EWhite613:list-item-redesign into * on ciena-frost:master*.

1 similar comment
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 415f91a on EWhite613:list-item-redesign into * on ciena-frost:master*.

@quincyle quincyle closed this Sep 21, 2016
@sglanzer-deprecated
Copy link
Contributor

Accidental close

@TheAxeMan301
Copy link

A bit old, mind closing this?

@sglanzer-deprecated
Copy link
Contributor

@TheAxeMan301 old, but still relevant, we need to hold this open until the redesign is pulled into available code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants