Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #171

Merged
merged 25 commits into from
Jan 25, 2018
Merged

Update dependencies #171

merged 25 commits into from
Jan 25, 2018

Conversation

juwara0
Copy link
Contributor

@juwara0 juwara0 commented Jan 25, 2018

This project uses semver, please check the scope of this pr:

  • #none# - documentation fixes and/or test additions
  • #patch# - backwards-compatible bug fix
  • #minor# - adding functionality in a backwards-compatible manner
  • #major# - incompatible API change

Closes: #167

CHANGELOG

  • Added ignore the linting of the CHANGELOG.md
  • Added ignoring of package-lock until we are ready to move to node 8
  • Removed useLintTree ember-cli-mocha configuration from ember-cli-build.js
  • Removed .remarkrc file since it is now provided by ember-test-utils
  • Updated ember-frost-test to ^4.0.0
  • Updated ember-cli-chai to 0.4.3
  • Updated ember-cli-mocha to 0.14.4
  • Updated ember-sinon to ^0.7.0
  • Updated ember-test-utils to ^8.1.0
  • Updated sinon-chai @ ^2.14.0
  • Updated ember-cli-code-coverage to 0.3.12
  • Updated ember-cli-frost-blueprints to ^5.0.1
  • Updated ember-cli-notifications to ^4.2.1
  • Updated pin ember-code-snippet to 1.7.0
  • Updated ember-frost-sort to ^10.0.0
  • Removed unused ember-async-image package
  • Removed unused pull-report package
  • Added broccoli-funnel @ ^2.0.1
  • Added broccoli-merge-trees @ ^2.0.0
  • Updated ember-cli-sass to 7.1.1
  • Updated ember-frost-core to ^5.1.1
  • Updated ember-hook to 1.4.2
  • Updated ember-prop-types to ^6.0.1
  • Updated ember-truth-helpers to ^1.3.0`
  • Updated ua-parser-js to ^0.7.17
  • Removed static copy of ua-parser-js.js located in vendor/
  • Added a vendor shim to enable import of ua-parser-js npm package
  • Updated index.js file to add ua-parser-js to this add-on's build tree
  • Updated usage of UAParser to use new importable module instead of global
  • Updated move code coverage config file to tests/dummy/config/
  • Removed unused animation-frame bower package
  • Updated Faker and jquery-mockjax bower packages to be devDependencies

@juwara0 juwara0 requested a review from notmessenger January 25, 2018 16:12
}

define('ua-parser-js', [], vendorModule);
})();
Copy link
Contributor

@notmessenger notmessenger Jan 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want a semi-colon at the end of this? Or any of the lines for that matter.

As an aside, do we need to open an issue for our linter to lint these files as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been updated to comply with our linting standards.

@notmessenger
Copy link
Contributor

notmessenger commented Jan 25, 2018

👍

Approved with PullApprove

@juwara0 juwara0 merged commit a44c630 into ciena-frost:master Jan 25, 2018
@juwara0 juwara0 deleted the updateDependencies branch January 25, 2018 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address dependency management issues
2 participants