Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when installed into an app running v2.14.1 of Ember #474

Open
notmessenger opened this issue Jul 14, 2017 · 6 comments
Open

Error when installed into an app running v2.14.1 of Ember #474

notmessenger opened this issue Jul 14, 2017 · 6 comments
Labels

Comments

@notmessenger
Copy link
Contributor

STEPS TO REPLICATE

  1. Install [email protected]
  2. Run ember new testApp
  3. Run ember install ember-frost-core
  4. Run ember s and receive this error:
The Broccoli Plugin: [BroccoliMergeTrees] failed with:
TypeError: The plugin [null,{}] didn't export a Plugin instance
    at PluginManager.validate (my-project/node_modules/ember-frost-core/node_modules/babel-core/lib/transformation/file/plugin-manager.js:164:13)
    at PluginManager.add (my-project/node_modules/ember-frost-core/node_modules/babel-core/lib/transformation/file/plugin-manager.js:213:10)
    at File.buildTransformers (my-project/node_modules/ember-frost-core/node_modules/babel-core/lib/transformation/file/index.js:237:21)
    at new File (my-project/node_modules/ember-frost-core/node_modules/babel-core/lib/transformation/file/index.js:139:10)
    at Pipeline.transform (my-project/node_modules/ember-frost-core/node_modules/babel-core/lib/transformation/pipeline.js:164:16)
    at my-project/node_modules/ember-frost-core/node_modules/broccoli-babel-transpiler/lib/parallel-api.js:102:26
    at initializePromise (my-project/node_modules/rsvp/dist/rsvp.js:567:5)
    at new Promise (my-project/node_modules/rsvp/dist/rsvp.js:1033:31)
    at Object.transformString (my-project/node_modules/ember-frost-core/node_modules/broccoli-babel-transpiler/lib/parallel-api.js:101:12)
    at Babel.transform (my-project/node_modules/ember-frost-core/node_modules/broccoli-babel-transpiler/index.js:110:22)

The broccoli plugin was instantiated at:
    at BroccoliMergeTrees.Plugin (my-project/node_modules/broccoli-plugin/index.js:7:31)
    at new BroccoliMergeTrees (my-project/node_modules/broccoli-merge-trees/index.js:42:10)
    at BroccoliMergeTrees (my-project/node_modules/broccoli-merge-trees/index.js:36:53)
    at Class.treeForAddon (my-project/node_modules/ember-frost-core/index.js:190:12)
    at Class.superWrapper [as treeForAddon] (my-project/node_modules/core-object/lib/assign-properties.js:34:20)
    at Class._treeFor (my-project/node_modules/ember-cli/lib/models/addon.js:551:33)
    at Class.treeFor (my-project/node_modules/ember-cli/lib/models/addon.js:511:21)
    at project.addons.map.addon (my-project/node_modules/ember-cli/lib/broccoli/ember-app.js:557:22)
    at Array.map (native)
    at EmberApp.addonTreesFor (my-project/node_modules/ember-cli/lib/broccoli/ember-app.js:555:32)
@notmessenger
Copy link
Contributor Author

This seems like a possible lead, especially with the fix that was implemented - ember-cli/ember-cli-mocha#182

Specifically that it may not be an "obvious" reason.

@notmessenger
Copy link
Contributor Author

notmessenger commented Jul 14, 2017

The problem is due to a mismatch in the versions of ember-cli-babel. If the application's version of ember-cli-babel is changed from ^6.3.0 to ^5.1.7 and the version of ember-cli-htmlbars-inline-precompile is changed from ^0.4.3 to ^0.3.0 then the application will build/serve without encountering this error.

@dguayrobotiq
Copy link

Is this fixed? I'm trying to update ember-cli to 2.18.0 and since ember-frost-core needs these old versions, I just can't upgrade without encountering multiple errors.

@notmessenger
Copy link
Contributor Author

@dguayrobotiq This has not yet been fixed. ciena-blueplanet/ember-prop-types#158 (comment) provides more insight into the reason it has not been and when we are planning to do so.

@dguayrobotiq
Copy link

@notmessenger If I understand it correctly, If I want to upgrade to ember-cli 2.13+, all of my dependencies need to use ember-cli 2.13+?

@notmessenger
Copy link
Contributor Author

notmessenger commented Mar 24, 2018

According to https://emberjs.com/blog/2017/04/29/ember-2-13-released.html

Babel 6 support has been added to Ember CLI internally and is now used by default for newly generated projects (both applications and addons). Due to the way that Ember CLI handles transpilation this transition can be done gradually by updating each addon to utilize newer versions of ember-cli-babel.

Which reads to me as if the transition from Babel 5 to Babel 6 should have never caused an issue (other than needing to change the version of ember-cli-babel being used) yet this change is specifically causing us issues and we have not been able to work in a mixed Babel environment.

We have not been able to determine whether others are experiencing similar issues (with apps and other addons (not ours)) or if enough projects moved forward around the time this switch over occurred that it didn't really manifest itself. We have not seen any conversation in the community about the difficulties we have been experiencing so it is possible that this is a problem of our own making but we have not been able to determine what the issue is which would then allow us to do so piecemeal rather than having to do all at once (we have around 75 addons and dozens of apps). To say that this is impacting us, and by extension others such as yourself, is an understatement. We began having meetings this past week to figure out our game plan and we are going to dedicate some time to specifically digging into this problem and re-creating it as a smaller scale so we can involve the community at large in discovering a solution (besides just upgrading everything which is our ultimate desired end goal).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants