Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPRECATION: An addon is trying to access project.nodeModulesPath. #52

Open
9 tasks done
eturino opened this issue Apr 3, 2018 · 1 comment
Open
9 tasks done

Comments

@eturino
Copy link

eturino commented Apr 3, 2018

DEPRECATION REPORT

  • I have ensured that the issue isn't already reported
  • I have confirmed that the issue is reproducible with the latest released version
  • I have deleted the FEATURE REQUEST / CODE CHANGE section

Summary

When building with later ember 2.x, we see the following message:

DEPRECATION: An addon is trying to access project.nodeModulesPath. This is not a reliable way to discover npm modules. Instead, consider doing: require("resolve").sync(something, { basedir: project.root }). Accessed from:   new NPMDependencyVersionChecker (/PROJECT_ROOT/node_modules/ember-spread/node_modules/ember-cli-version-checker/src/npm-dependency-version-checker.js:11:33)

When building with ember 3.x we see the following message:

DEPRECATION: ember-cli-babel 5.x has been deprecated. Please upgrade to at least ember-cli-babel 6.6. Version 5.2.8 located: ember-mat-design-mock -> ember-spread -> ember-cli-babel
DEPRECATION: ember-cli-babel 5.x has been deprecated. Please upgrade to at least ember-cli-babel 6.6. Version 5.2.8 located: ember-mat-design-mock -> ember-spread -> ember-prop-types -> ember-cli-babel
DEPRECATION: ember-cli-babel 5.x has been deprecated. Please upgrade to at least ember-cli-babel 6.6. Version 5.2.8 located: ember-mat-design-mock -> ember-spread -> ember-prop-types -> ember-get-config -> ember-cli-babel
DEPRECATION: ember-cli-babel 5.x has been deprecated. Please upgrade to at least ember-cli-babel 6.6. Version 5.2.8 located: ember-mat-design-mock -> ember-spread -> ember-prop-types -> ember-string-ishtmlsafe-polyfill -> ember-cli-babel

Expected Behavior

No deprecation warnings on build

Actual Behavior

Possible Solution

It seems to be ember-cli/ember-cli-version-checker#48

Updating to ember-cli-babel 6.6 or later seems to be the solution. ember-cli-babel 5.x is deprecated.

Steps to Reproduce

$ yarn global add ember-cli

$ ember --version
ember-cli: 3.0.2
node: 8.9.1
os: darwin x64

$ ember new testing-ember-spread

$ cd testing-ember-spread

$ ember i ember-spread
npm: Installed ember-spread
DEPRECATION: ember-cli-babel 5.x has been deprecated. Please upgrade to at least ember-cli-babel 6.6. Version 5.2.8 located: ember-mat-design-mock -> ember-spread -> ember-cli-babel
DEPRECATION: ember-cli-babel 5.x has been deprecated. Please upgrade to at least ember-cli-babel 6.6. Version 5.2.8 located: ember-mat-design-mock -> ember-spread -> ember-prop-types -> ember-cli-babel
DEPRECATION: ember-cli-babel 5.x has been deprecated. Please upgrade to at least ember-cli-babel 6.6. Version 5.2.8 located: ember-mat-design-mock -> ember-spread -> ember-prop-types -> ember-get-config -> ember-cli-babel
DEPRECATION: ember-cli-babel 5.x has been deprecated. Please upgrade to at least ember-cli-babel 6.6. Version 5.2.8 located: ember-mat-design-mock -> ember-spread -> ember-prop-types -> ember-string-ishtmlsafe-polyfill -> ember-cli-babel
Installed addon package.

Context

we are trying to upgrade our app to use ember 3, and this addon is one of the few ones still to fix the deprecations.

Environment

(answer all that are applicable)

  • I am using the latest released version (can check with npm ls <package-name>)
  • I am using these browsers:
    • Latest Chrome
    • Latest Firefox
  • My version of Node is: v8.9.1 (I can't build the addon for development because of error [email protected]: The engine "node" is incompatible with this module. Expected version "^4.5 || 6.* || 7.*".)
  • My version of npm is: 5.5.1
  • My OS is: MacOS High Sierra
@notmessenger
Copy link
Contributor

Thank you for this submission. We are actively working to put together an upgrade plan for this repo (we are actually looking into these exact deprecations in a branch right now) and the rest in our organization.

More information about this can be found in ciena-frost/ember-frost-core#474 and ciena-blueplanet/ember-prop-types#158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants