Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify whether this works with Ember 3+ #56

Open
3 tasks done
gabrielgrant opened this issue May 25, 2018 · 3 comments
Open
3 tasks done

Clarify whether this works with Ember 3+ #56

gabrielgrant opened this issue May 25, 2018 · 3 comments

Comments

@gabrielgrant
Copy link

gabrielgrant commented May 25, 2018

BUG REPORT

  • I have ensured that the issue isn't already reported
  • I have confirmed that the issue is reproducible with the latest released version
  • I have deleted the FEATURE REQUEST / CODE CHANGE section

Summary

options set on a component with SpreadMixin don't seem to actually spread on an Ember 3.1 app.
I am seeing the deprecation warnings in #52 / #55 but it's unclear to me whether it's expected that this should still be working post 3.0 or if deprecated features that this depends on have been removed. It would be useful if info about which versions are expected to work were included in the README (particularly if it's not all of them)

Expected Behavior

spread-age!

Actual Behavior

options property is set on the component, but the individual properties contained in the hash are not

@dknutsen
Copy link

So I know this issue is kinda old now and I'll say upfront that I haven't done any comprehensive testing but I just made a simple example app with a component that dynamically renders another component with ember-spread in Ember 3.3 and it works exactly as expected.

@gabrielgrant
Copy link
Author

Hmmm, strange. I think I removed all our usage of it as part of our 3.0 upgrade, but thanks for the heads-up/putting it back on my radar.

@EWhite613
Copy link
Contributor

EWhite613 commented Sep 1, 2022

So this works in 3.16. Provided you are not using glimmer components. Also it's not gonna spread into the this.args.<prop> (which is the advised way to use properties passed in)

I believe everyone is basically waiting on emberjs/rfcs#593 for a native approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants