Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(icon-fingerprinting): Scaffolding for iconAsset fp #427

Closed
wants to merge 2 commits into from
Closed

feature(icon-fingerprinting): Scaffolding for iconAsset fp #427

wants to merge 2 commits into from

Conversation

srowhani
Copy link
Contributor

@srowhani srowhani commented Mar 31, 2017 •
edited
Loading

This project uses semver, please check the scope of this pr:

  • #none# - documentation fixes and/or test additions
  • #patch# - backwards-compatible bug fix
  • #minor# - adding functionality in a backwards-compatible manner
  • #major# - incompatible API change

For now this intends to be a proof of concept, and should not be merged.

How it works

  • Use broccoli-asset-rev to wrap pre-existing treeForPublic
    • By default b-a-r will ignore svg files
  • Generate asset map
  • Create an application initializer that defers app readiness state and injects assetMap
  • Frost icon refers to the icon pack through a CP

CHANGELOG

  • Icon packs are now fingerprinted

Closes #424

@srowhani
Copy link
Contributor Author

Closed in favor of #429

@srowhani srowhani closed this Apr 10, 2017
@job13er job13er mentioned this pull request Jun 7, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@job13er job13er

@sglanzer-deprecated sglanzer-deprecated

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Icon packs are not fingerprinted
4 participants
@srowhani @job13er @juwara0 @sglanzer-deprecated