Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon packs are not fingerprinted #424

Open
job13er opened this issue Mar 28, 2017 · 5 comments
Open

Icon packs are not fingerprinted #424

job13er opened this issue Mar 28, 2017 · 5 comments

Comments

@job13er
Copy link
Contributor

job13er commented Mar 28, 2017

When doing a production build, most of our base assets are fingerprinted, which helps with cache issues when we update the app. However, icon packs are not among those resources which receive fingerprints.

The current implementation of frost-icon would not work if the icon packs received fingerprints either:

<use xlink:href="assets/icon-packs/{{pack}}.svg#{{icon}}" />

It would be great if we had some mechanism for identifying the version of the icon-pack .svg files so that browsers always had the proper version w/o users needing to clear their cache.

@job13er
Copy link
Contributor Author

job13er commented Jun 7, 2017

I'm re-opening this because I believe it's still an issue with #432 having reverted the change delivered in #427 that closed this.

@job13er job13er reopened this Jun 7, 2017
@job13er
Copy link
Contributor Author

job13er commented Jun 7, 2017

@sglanzer Just wondering if there's any update on the second try at implementing this?

@sglanzer-deprecated
Copy link
Contributor

@job13er was #429 reverted? If so we can look at another pass at this, but it'll be in the second half of June

@job13er
Copy link
Contributor Author

job13er commented Jun 7, 2017

@notmessenger
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants