-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icon packs are not fingerprinted #424
Labels
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When doing a production build, most of our base assets are fingerprinted, which helps with cache issues when we update the app. However, icon packs are not among those resources which receive fingerprints.
The current implementation of
frost-icon
would not work if the icon packs received fingerprints either:ember-frost-core/addon/templates/components/frost-icon.hbs
Line 2 in 81e9629
It would be great if we had some mechanism for identifying the version of the icon-pack
.svg
files so that browsers always had the proper version w/o users needing to clear their cache.The text was updated successfully, but these errors were encountered: