Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update targetObject to target to fix deprecation notice #53

Merged
merged 1 commit into from
Apr 25, 2018

Conversation

juwara0
Copy link
Contributor

@juwara0 juwara0 commented Apr 24, 2018

Overview

Does this PR close an existing issue?

Yes, this issue addresses the issue opened for the deprecation notice on targetObject

Summary

Usage of targetObject is now deprecated and recommended to use target instead

Issue Number(s)

Which issue(s) does this PR address?

Put Closes #XXXX below to auto-close the issue that this PR addresses:

Screenshots or recordings

Please provide screenshots or recordings if this PR is modifying the visual UI or UX.

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have evaluated if the README.md documentation needs to be updated
  • I have evaluated if the /tests/dummy/ app needs to be modified
  • I have evaluated if DocBlock headers needed to be added or updated
  • I have verified that lint and tests pass locally with my changes
  • If a fork of a dependent package had to be made to address the issue this PR closes:
    • I noted in the fork's README.md the reason the fork was created
    • I have opened an upstream issue detailing what was deficient about the dependency
    • I have opened an upstream PR addressing this deficiency
    • I have opened an issue in this repository to track this PR and schedule the removal of the usage of the fork

Semver

This project uses semver, please check the scope of this PR:

  • #none#
  • #patch#
  • #minor#
  • #major#

Examples:

  • NONE
    • README.md changes
    • test additions
    • changes to files that are not used by a consuming application (.travis.yml, .gitignore, etc)
  • PATCH
    • backwards-compatible bug fix
      • nothing about how to use the code has changed
      • nothing about the outcome of the code has changed (though it likely corrected it)
    • changes to demo app (/tests/dummy/)
  • MINOR
    • adding functionality in a backwards-compatible manner
      • nothing about how used to use the code has changed but using it in a new way will do new things
      • nothing about the outcome of the code has changed without having to first use it in a new way
      • addition of new CSS selectors
      • addition of new ember-hook selectors
  • MAJOR
    • incompatible API change
      • using the code how used to will cease working
      • using the code how used to will have a different outcome
      • any changes to CSS selector names
      • any removal of CSS selectors
      • any changes to ember-hook selectors
      • possibly changes to test helpers (depends on the changes made)
    • any changes to the dependencies entry in the package.json file

CHANGELOG

@juwara0 juwara0 requested a review from notmessenger April 24, 2018 19:44
@juwara0 juwara0 requested a review from a team as a code owner April 24, 2018 19:44
@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling 8e2d6f6 on juwara0:targetObjectDeprecation into 335e221 on ciena-blueplanet:master.

@juwara0 juwara0 merged commit 9fa20ad into ciena-blueplanet:master Apr 25, 2018
@juwara0 juwara0 deleted the targetObjectDeprecation branch April 25, 2018 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants