GH-54 fix: remove references to "reviews" field in blogPost documents,

Also disable server-side recipe structured data
ciampo · Jul 31, 2020 · bd031f7 · bd031f7
1 parent 93084b7
commit bd031f7
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 20 deletions.
diff --git a/pages-tests/blogpost.test.tsx b/pages-tests/blogpost.test.tsx
@@ -17,8 +17,8 @@ const blogPostData = testRecipeData as SanityBlogPostFull;
 
 jest.mock('../components/blog-post/sanity-browser-client', () => {
   return {
-    getPostReviews: (): { reviews: number[] } => {
-      return { reviews: [1, 5, 3] };
+    getPostReviews: (): { rating: number }[] => {
+      return [{ rating: 1 }, { rating: 5 }, { rating: 3 }];
     },
   };
 });

diff --git a/pages-tests/data/test-category.json b/pages-tests/data/test-category.json
@@ -105,8 +105,7 @@
           "categoryId": "test-category",
           "postId": "blog-post-slug"
         }
-      },
-      "reviews": []
+      }
     }
   ],
   "featuredBlogPosts": [
@@ -214,8 +213,7 @@
           "categoryId": "test-category",
           "postId": "blog-post-slug"
         }
-      },
-      "reviews": []
+      }
     }
   ],
   "name": "Test category",

diff --git a/sanity/blogPost.js b/sanity/blogPost.js
@@ -26,7 +26,6 @@ const allBlogPostsQuery = /* groq */ `*[_type == "${blogPostType}"] {
   "seoTitle": ${pageBlogPostQuery}[0].seoTitle,
   "seoDescription": ${pageBlogPostQuery}[0].seoDescription,
   "seoImage": seoImage.asset->url,
-  "reviews": coalesce(reviews[], []),
 }`;
 
 function replaceBlogPostContent(blogPostItem, content) {

diff --git a/sanity/projections.js b/sanity/projections.js
@@ -137,7 +137,6 @@ const blogPostPreviewProjection = /* groq */ `{
   "tags":tags[]->${tagPreviewProjection},
   datePublished,
   previewImage->${accessibleImageProjection},
-  "reviews": coalesce(reviews[], []),
 }`;
 
 module.exports = {

diff --git a/scripts/structured-data.ts b/scripts/structured-data.ts
@@ -182,17 +182,17 @@ export function generateRecipeStructuredData({
     // Missing: video
   };
 
-  if (blogPostData.reviews.length) {
-    toReturn.aggregateRating = {
-      '@type': 'AggregateRating',
-      reviewCount: blogPostData.reviews.length,
-      ratingValue:
-        Math.round(
-          (100 * blogPostData.reviews.reduce((acc, curr) => acc + curr, 0)) /
-            blogPostData.reviews.length
-        ) / 100,
-    };
-  }
+  // if (blogPostData.reviews.length) {
+  //   toReturn.aggregateRating = {
+  //     '@type': 'AggregateRating',
+  //     reviewCount: blogPostData.reviews.length,
+  //     ratingValue:
+  //       Math.round(
+  //         (100 * blogPostData.reviews.reduce((acc, curr) => acc + curr, 0)) /
+  //           blogPostData.reviews.length
+  //       ) / 100,
+  //   };
+  // }
 
   return toReturn;
 }

diff --git a/typings/sanity-blog-post.ts b/typings/sanity-blog-post.ts
@@ -15,7 +15,6 @@ export type SanityBlogPostBase = {
   category: SanityCategoryPreview;
   tags: SanityTag[];
   datePublished: string;
-  reviews: number[];
 };
 
 export type SanityBlogPostPreview = SanityBlogPostBase & {