Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Col, Row fixed tests and linter #64

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

bartoszhernas
Copy link

@bartoszhernas bartoszhernas commented Aug 3, 2018

Hi,

continuing work on #54 (and #33), I have fixed test suite and linter.

@codecov-io
Copy link

Codecov Report

Merging #64 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #64   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     14    +2     
  Lines          65     71    +6     
  Branches       13     13           
=====================================
+ Hits           65     71    +6
Impacted Files Coverage Δ
src/components/A.jsx 100% <ø> (ø) ⬆️
src/index.js 100% <ø> (ø) ⬆️
examples/kitchenSink.jsx 100% <ø> (ø) ⬆️
src/components/Row.jsx 100% <100%> (ø)
src/components/Col.jsx 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42d6bd7...3f1311c. Read the comment docs.

@bartoszhernas
Copy link
Author

@Razzwan can you merge ? :)

@Razzwan
Copy link

Razzwan commented Apr 19, 2020

I have no access

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants