Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix polling manager thread shut down #248

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Conversation

christophebedard
Copy link
Owner

Part of #247

This doesn't solve everything. It fixes the shutdown of the polling thread, but then there's another issue.

Signed-off-by: Christophe Bedard [email protected]

Signed-off-by: Christophe Bedard <[email protected]>
@christophebedard christophebedard added the bug Something isn't working label Aug 17, 2021
@christophebedard christophebedard self-assigned this Aug 17, 2021
@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #248 (1032515) into master (9db2a56) will decrease coverage by 0.02%.
The diff coverage is 6.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #248      +/-   ##
==========================================
- Coverage   15.95%   15.93%   -0.03%     
==========================================
  Files          78       77       -1     
  Lines        1999     2008       +9     
  Branches      971      980       +9     
==========================================
+ Hits          319      320       +1     
- Misses       1489     1496       +7     
- Partials      191      192       +1     
Flag Coverage Δ
unittests 15.93% <6.25%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
email/src/context.cpp 0.00% <0.00%> (ø)
email/src/email/polling_manager.cpp 0.00% <0.00%> (ø)
rmw_email_cpp/src/rmw_init.cpp 0.00% <0.00%> (ø)
email/src/log.cpp 65.97% <50.00%> (-0.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9db2a56...1032515. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant