Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for volume mounts in skooner #1178

Merged
merged 1 commit into from
Oct 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions charts/skooner/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: skooner
description: Simple Kubernetes real-time dashboard and management.
type: application
version: 0.0.10
version: 0.0.11
appVersion: "stable"
home: https://github.com/christianhuth/helm-charts
icon: https://encrypted-tbn0.gstatic.com/images?q=tbn:ANd9GcRu8eQrFBosk7yHTiDEwjnVcMRyDD5uIaNXhlZ1m0yiC4H8RP1j0PlBPtgtv0bdH0JwlOE
Expand All @@ -15,7 +15,7 @@ annotations:
artifacthub.io/category: monitoring-logging
artifacthub.io/changes: |
- kind: changed
description: added support for stable autoscaling api
description: added support for volume mounts
artifacthub.io/screenshots: |
- title: Overview of the workloads running inside of Kubernetes.
url: https://skooner.io/images/k8dash-screen.png
Expand Down
3 changes: 3 additions & 0 deletions charts/skooner/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,9 @@ The command removes all the Kubernetes components associated with the chart and
| serviceAccount.create | bool | `true` | Specifies whether a service account should be created |
| serviceAccount.name | string | `""` | The name of the service account to use. If not set and create is true, a name is generated using the fullname template |
| tolerations | list | `[]` | Toleration labels for pod assignment |
| volumeMounts | list | `[]` | Container's volume mounts |
| volumes | list | `[]` | Pod's volumes |


Specify each parameter using the `--set key=value[,key=value]` argument to `helm install`.

Expand Down
8 changes: 8 additions & 0 deletions charts/skooner/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@ spec:
resources:
{{- toYaml . | nindent 12 }}
{{- end }}
{{- with .Values.volumeMounts }}
volumeMounts:
{{- toYaml . | nindent 12 }}
{{- end }}
{{- if .Values.oidc.enabled }}
env:
- name: OIDC_URL
Expand Down Expand Up @@ -77,3 +81,7 @@ spec:
tolerations:
{{- toYaml . | nindent 8 }}
{{- end }}
{{- with .Values.volumes}}
volumes:
{{- toYaml . | nindent 8 }}
{{- end }}
6 changes: 6 additions & 0 deletions charts/skooner/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,12 @@
},
"tolerations": {
"type": "array"
},
"volumeMounts": {
"type": "array"
},
"volumes": {
"type": "array"
}
}
}
6 changes: 6 additions & 0 deletions charts/skooner/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -115,3 +115,9 @@ oidc:
clusterRoleBinding:
# -- Define which ClusterRole to bind to: cluster-admin, edit, view
clusterRole: edit

# -- Container's volume mounts
volumeMounts: []

# -- Pod's volumes
volumes: []
Loading