-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storybook Relaunch #625
Open
leoalfonso14
wants to merge
28
commits into
main
Choose a base branch
from
storybook-relaunch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Storybook Relaunch #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
codingwithlis
previously approved these changes
Oct 26, 2023
AddToCalendar Story - not functional AppHead - empty BirthDateField Chat - error - no auth
Collection Preview CommunityActionSection CommunityLeaderActions CommunityList - work in progress
dzwood
added
Ready for Review ✅
PR is Ready for Review
and removed
🛑 DO NOT MERGE 🛑
labels
Dec 6, 2023
leoalfonso14
added
Enhancement ✨
New feature or request
In Progress 👨💻
and removed
Ready for Review ✅
PR is Ready for Review
labels
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This PR updates and adds our components and ui-kit elements to storybook for better and more consistent testing.
Test Instructions
yarn && yarn storybook
on the terminal (on thestorybook-relaunch
branch), it should open the storybook page once it finishes loading, but if it does not, go to localhost:6006.Screenshots
Closes Tickets
CFDP-2789
More To Add
Missing UI:
* Horizontal Scroll - still has not been merged into main
* HTML Render & Img
* Modal
* Theme Provider
* Value Stack
Missing Components:
* Community Single
* ContentBlockFeature
* Content Layout
* Content List
* Content Single
* Custom Link
* Discover Filter Section
* Discover Filter Map
* Event Single
* External Home
* Feature Feed
* Gender Field
* Generic Error
* Gradient Background
* Group Email Component
* Group Manage
* Groups Single
* Groups List
* Group Search Filters
* Groups Search Side Bar
* Group Resource List
* Hero Landing
* Home Feed
* Info Card List
* Layout
* Legacy Node Router
* Live Steam Single
* Location Block Feature
* Location Single
* Logo
* Mobile Nav Screen
* MODALS ******** A lot of these inside
* Nav
* Not Found
* Page Single
* Password Reset
* Search Field
* Share
* Testimonials
* Track Event When Loaded
* User Avatar
* User Profile
* Video
* Wistia Player