Typescript types #34
Merged
Typescript types #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uhm... weird. Tests seem to be passing but the exitcode is still 1. Seems to also be happening on master. Is this normal? |
|
Our tests seem to pass or fail somewhat unpredictably. I'll pull it down and test just to verify but I would imagine it's probably fine. Thanks for the pull request! |
|
@chrisjpatty Ok, let me know if any changes are necessary. |
|
In the mean time, the types got merged into the Definitely Typed repository and are already available through npm ( |
chrisjpatty
approved these changes
Aug 16, 2018
|
Sorry I'm just getting around to this. Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #33.
I also updated the build script to include the copy of these types. Please let me know if you see something is off or if you want me to make some other change (like a minor version bump).