Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript types for DefinitelyTyped repository #33

Open
nscarcella opened this issue Jul 30, 2018 · 6 comments
Open

Typescript types for DefinitelyTyped repository #33

nscarcella opened this issue Jul 30, 2018 · 6 comments

Comments

@nscarcella
Copy link
Contributor

Hello!

Before anything else: thanks for this great library! I spent so much time looking for a way to cleanly handle d&d I started to believe there was no easy way.

I would very much like to use this on my TypeScript projects, but I noticed there is no type definition published for it on DefinitelyTyped, so I took the liberty of translating the .js.flow file to a TypeScript module and made a pull request (you can find it here).

I hope this is OK with you and, of course, if you want to review the pull request and add your own feedback, it would be very welcome.

Best regards.

@chrisjpatty
Copy link
Owner

Thanks @nscarcella! I'm personally not very familiar with Typescript or Flow, @TrySound has graciously provided all of the flowtype support for dragtastic. Thanks for transcribing it into TypeScript. As the dragtastic api changes over time, would you like to be notified so you can update the typescript definitions?

@TrySound
Copy link
Collaborator

It's always better to keep definitions in source repo so they could easily be updated.

@chrisjpatty
Copy link
Owner

I guess I'm not familiar with DefinitelyTyped. Is it a repository of typescript definitions, or just a directory that links to repositories with typescript definitions. I agree that it probably makes sense to maintain them with the source repo so they stay in sync.

@TrySound
Copy link
Collaborator

It's a repo with definitions.

@chrisjpatty
Copy link
Owner

Ah, makes sense. @nscarcella would you be willing to open a pull request into this repo with your definitions included? That way there's a more central place to make sure they stay updated.

nscarcella added a commit to nscarcella/react-dragtastic that referenced this issue Aug 1, 2018
@nscarcella
Copy link
Contributor Author

Hi @chrisjpatty, @TrySound is right, adding the types to the core would be the absolute best.
I just made a PR with the necessary changes and I'll be happy to help maintain it in my spare time, just send me a notification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants