-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript types for DefinitelyTyped repository #33
Comments
Thanks @nscarcella! I'm personally not very familiar with Typescript or Flow, @TrySound has graciously provided all of the flowtype support for dragtastic. Thanks for transcribing it into TypeScript. As the dragtastic api changes over time, would you like to be notified so you can update the typescript definitions? |
It's always better to keep definitions in source repo so they could easily be updated. |
I guess I'm not familiar with |
It's a repo with definitions. |
Ah, makes sense. @nscarcella would you be willing to open a pull request into this repo with your definitions included? That way there's a more central place to make sure they stay updated. |
Hi @chrisjpatty, @TrySound is right, adding the types to the core would be the absolute best. |
Hello!
Before anything else: thanks for this great library! I spent so much time looking for a way to cleanly handle d&d I started to believe there was no easy way.
I would very much like to use this on my TypeScript projects, but I noticed there is no type definition published for it on DefinitelyTyped, so I took the liberty of translating the
.js.flow
file to a TypeScript module and made a pull request (you can find it here).I hope this is OK with you and, of course, if you want to review the pull request and add your own feedback, it would be very welcome.
Best regards.
The text was updated successfully, but these errors were encountered: