Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Edit Message route #232

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implement Edit Message route #232

wants to merge 1 commit into from

Conversation

manoedinata
Copy link

@manoedinata manoedinata commented Jun 13, 2024 •
edited
Loading

@manoedinata
Copy link
Author

Should work well, haven't tested yet, working on something else.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@manoedinata manoedinata mentioned this pull request Jun 13, 2024
Open
avoylenko
avoylenko requested changes Oct 14, 2024
View reviewed changes
src/controllers/messageController.js
const client = sessions.get(req.params.sessionId)
const message = await _getMessageById(client, messageId, chatId)
if (!message) { throw new Error('Message not Found') }
const editedMessage = await message.edit(content, options)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make options be optional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avoylenko avoylenko avoylenko requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manoedinata @avoylenko