Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDYelpReview timeCreatedAsDate() needs special date formatter #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

davecom
Copy link
Contributor

@davecom davecom commented Dec 25, 2022

Goals ⚽

  • Use the right date formatter for CDYelpReview's timeCreatedAsDate() so it doesn't fail

Implementation Details 🚧

  • Switched to use the DateFormatter reviews already defined in an extension

Testing Details 🔍

Tested using this formatter in my own extension of CDYelpReview

@chrisdhaan
Copy link
Owner

Thanks for this @davecom. I'll take a look and get this merged in this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants