Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added initial state functionality to modules. #23

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

lucasconstantino
Copy link
Contributor

No description provided.

@sebas5384
Copy link
Contributor

@lucasconstantino I think this PR is doing some refactors which could be in different PR in order to review it better.

The code of which enables the initial state for modules is really great, and I think we can do it in a way it isn't close the door to Immutable libraries (for example ImmutableJS).

Given that I think we can do PR which enables the developers to extend the processModules and implement more behaviors like this one.

@recidive and @lucasconstantino how we could do the initial state handled in way we don't loose compatibility with immutable libraries?

@sebas5384
Copy link
Contributor

@lucasconstantino I did PR over this issue, to avoid the mutation of state object passed as reference.
Let me know what you think, @recidive gives me his "ok", so if you agree on this please make the merge of lucasconstantino/redux-boot@initial-state...sebas5384:patch-1 and I'll merge this PR right away!

Removed mutation of the state passed as reference.
@lucasconstantino
Copy link
Contributor Author

Done ;)

@sebas5384
Copy link
Contributor

@lucasconstantino awesome!!

Oh! I think we forgot the documentation, so I'll document it and send you a PR later 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants