Fix/support python 310 #1286
Open
Fix/support python 310 #1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for fixing this! Option 1 sounds good. Maybe we can get some other critical bugfixes in as well? |
|
That is a good idea, if you have time (and I saw that you started this) try and tag any PRs or issues into this milestone https://github.com/choderalab/yank/milestone/11 It would be nice to get some fixes in + get CI working again |
|
Resolves #1288 |
Closed
3 tasks
|
@ijpulidos thanks for working on this! We are getting closer! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In python 3.10, Mapping and MutableMapping live in collections.abc and not collections. This supports importing Mapping and MutableMapping from python 3.10 and < python 3.10
We can either add this and bump yank version + cut new yank release OR just change conda-forge to not support python 3.10 for yank since CI is failing conda-forge/yank-feedstock#4
@jchodera do you have a preference?
option 1:
merge in PR, bump yank version, new release on conda-forge
option 2:
set yank on conda-forge to < python 3.10
Resolves #1301