Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow n_rounds to be passed to stability_oracle_factory #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zhang-ivy
Copy link
Contributor

Fixes some problems introduced by #3

@zhang-ivy zhang-ivy requested a review from maxentile October 19, 2020 15:57
Copy link
Member

@maxentile maxentile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, good catch! A quick search of the repository for other references to n_steps suggests you've now covered all the places this needs to be added.

Perhaps if we later expand the tests / examples, we could make sure the new arguments are covered by a new test.

@zhang-ivy
Copy link
Contributor Author

Hmm, one of the tests for mac os is failing:

_______________ ERROR collecting thresholds/tests/test_bisect.py _______________
ImportError while importing test module '/Users/travis/build/choderalab/thresholds/thresholds/tests/test_bisect.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
../../../miniconda3/envs/test/lib/python3.5/site-packages/numpy/core/__init__.py:16: in <module>
    from . import multiarray
E   ImportError: dlopen(/Users/travis/miniconda3/envs/test/lib/python3.5/site-packages/numpy/core/multiarray.cpython-35m-darwin.so, 2): Library not loaded: @rpath/libopenblas.dylib
E     Referenced from: /Users/travis/miniconda3/envs/test/lib/python3.5/site-packages/numpy/core/multiarray.cpython-35m-darwin.so
E     Reason: image not found
During handling of the above exception, another exception occurred:
thresholds/tests/test_bisect.py:1: in <module>
    import numpy as np
../../../miniconda3/envs/test/lib/python3.5/site-packages/numpy/__init__.py:142: in <module>
    from . import add_newdocs
../../../miniconda3/envs/test/lib/python3.5/site-packages/numpy/add_newdocs.py:13: in <module>
    from numpy.lib import add_newdoc
../../../miniconda3/envs/test/lib/python3.5/site-packages/numpy/lib/__init__.py:8: in <module>
    from .type_check import *
../../../miniconda3/envs/test/lib/python3.5/site-packages/numpy/lib/type_check.py:11: in <module>
    import numpy.core.numeric as _nx
../../../miniconda3/envs/test/lib/python3.5/site-packages/numpy/core/__init__.py:26: in <module>
    raise ImportError(msg)
E   ImportError: 
E   Importing the multiarray numpy extension module failed.  Most
E   likely you are trying to import a failed build of numpy.
E   If you're working with a numpy git repo, try `git clean -xdf` (removes all
E   files not under version control).  Otherwise reinstall numpy.
E   
E   Original error was: dlopen(/Users/travis/miniconda3/envs/test/lib/python3.5/site-packages/numpy/core/multiarray.cpython-35m-darwin.so, 2): Library not loaded: @rpath/libopenblas.dylib
E     Referenced from: /Users/travis/miniconda3/envs/test/lib/python3.5/site-packages/numpy/core/multiarray.cpython-35m-darwin.so
E     Reason: image not found

@jchodera
Copy link
Member

We probably just need to update the repo to use the most up to date cookiecutter, since .travis.yml and devtools/ are out of date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants