Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing against OpenMM dev/beta versions #637

Closed
wants to merge 1 commit into from

Conversation

ijpulidos
Copy link
Contributor

@ijpulidos ijpulidos commented Nov 28, 2022

Description

Testing against dev/beta versions of OpenMM.

Using conda-forge/label/openmm_dev label.

Resolves #636

Todos

  • Implement feature / fix bug
  • Add tests
  • Update documentation as needed
  • Update changelog to summarize changes in behavior, enhancements, and bugfixes implemented in this PR

Status

  • Ready to go

Changelog message


@ijpulidos ijpulidos requested a review from mikemhenry November 28, 2022 19:49
@mikemhenry
Copy link
Contributor

Good idea!

@mikemhenry
Copy link
Contributor

Looks like we are running into the same bugs we saw in #628

@ijpulidos
Copy link
Contributor Author

ijpulidos commented Nov 28, 2022

@mikemhenry The issue might be related, even though they look different from a first glance https://github.com/choderalab/openmmtools/actions/runs/3568138528/jobs/5996666286#step:8:2959

EDIT: Yes, they look like the same issue! Sorry for the confusion.

@ijpulidos
Copy link
Contributor Author

ijpulidos commented Nov 28, 2022

I cannot reproduce this issue locally, which suggests it is something different from choderalab/perses#1124 (which I can reproduce locally)

@ijpulidos
Copy link
Contributor Author

Closing, already implemented in #649 as far as I can see.

@ijpulidos ijpulidos closed this Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test against openmm 8 beta
2 participants