Expanded ensemble #421
Open
Expanded ensemble #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajsilveira
commented
May 10, 2019
ajsilveira
commented
- Include the option weight_update to perform expanded ensemble simulations
- minimum_visits and beta_factor are defined by the user
- set histogram as the default for flatness criteria
andrrizzi
reviewed
May 14, 2019
| @@ -628,7 +648,6 @@ def _update_logZ_estimates(self, replicas_log_P_k): | |||
| for (replica_index, state_index) in enumerate(self._replica_thermodynamic_states): | |||
| logger.debug(' Replica %d state %d' % (replica_index, state_index)) | |||
| # Compute attenuation factor gamma | |||
| beta_factor = 0.8 | |||
There was a problem hiding this comment.
This may be the main cause of test errors. The local variable beta_factor is deleted here, but I don't see self.beta_factor used anywhere.
Update everything to match MolSSI cookiecutter
|
Thank you! I think this is ready to be merged. Can you just update the |
|
This would be an "enhancement" in 0.19.0 version ? |
|
Yes, that works. |
Another small fix to release notes
Fix restrained atom indices
Co-Authored-By: Josh Fass <[email protected]>
…m/choderalab/openmmtools into loopy_alchemical_customintegrator
Fix travis since miniconda changed location
…ors from @domrufa)
…rium-integrator Add PeriodicNonequilibriumIntegrator
…ilibrium periodic integration cycle
…ilibrium Fix an issue with accidentally resetting PeriodicNonequilibriumIntegrator
Update neq integrator tests to generate trajectory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.