Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-444) Refactor code around Boxstarter specific parameters to make it clearer #445

Merged
merged 1 commit into from
Oct 14, 2020

Conversation

mwallner
Copy link
Member

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mwallner mwallner requested a review from pauby October 13, 2020 19:42
@mwallner mwallner self-assigned this Oct 13, 2020
@mwallner
Copy link
Member Author

this PR fixes GH-444

@mwallner mwallner changed the title do not pass StopOnPackageFailure to choco bad code - handling of 'Boxstarter exclusive parameters' (GH-444) Oct 13, 2020
@pauby pauby changed the title bad code - handling of 'Boxstarter exclusive parameters' (GH-444) (GH-444) Refactor code around Boxstarter specific parameters to make it clearer Oct 14, 2020
@pauby pauby merged commit 8459d49 into chocolatey:master Oct 14, 2020
@pauby
Copy link
Member

pauby commented Oct 14, 2020

Awesome work! Thanks for your contribution @mwallner!

@mwallner mwallner deleted the GH-444 branch April 27, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants