Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(python3-streams) Fix copyright reading logic and zip URL generation in python3-streams #2594

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

robmoss2k
Copy link

@robmoss2k robmoss2k commented Dec 10, 2024

Description

As per CPython issue #2672, alpha and beta builds have no official docs built. Furthermore, as of CPython PR #124489, the archives we previously referenced are no longer built. The change applies from Python 3.12 onwards based on what I can see in the docs archive.

Motivation and Context

The more recent versions of Python do not get packages built, as per Issue #2555. The previous PR did not work for the 3.14 alpha releases and, based on the CPython issue, may continue to break for new releases.

How Has this Been Tested?

I tested the Python3 update script directly and saw the correct versions referenced. I then tested via test_all.ps1 and again saw the correct versions referenced. I then used the generated package files and ran a local test install. I'm running PowerShell 7.4.6 on Windows 11.

Screenshot (if appropriate, usually isn't needed):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Migrated package (a package has been migrated from another repository)

Checklist:

  • My code follows the code style of this repository.
  • My change requires a change to documentation (this usually means the notes in the description of a package).
  • I have updated the documentation accordingly (this usually means the notes in the description of a package).
  • I have updated the package description and it is less than 4000 characters.
  • All files are up to date with the latest Contributing Guidelines
  • The added/modified package passed install/uninstall in the Chocolatey Test Environment(https://github.com/chocolatey-community/chocolatey-test-environment/). Note that we don't support the use of any other environment.
  • The changes only affect a single package (not including meta package).

@robmoss2k robmoss2k requested a review from a team as a code owner December 10, 2024 16:44
@robmoss2k robmoss2k requested a review from Windos December 10, 2024 16:44
@AppVeyorBot
Copy link

❌ Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look.

@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

@robmoss2k robmoss2k mentioned this pull request Dec 10, 2024
11 tasks
@yan12125
Copy link
Contributor

With this approach 3.14 works but 3.12 fails. Could you have a look?

Downloading to python-3.12.8.exe - https://www.python.org/ftp/python/3.12.8/python-3.12.8.exe
Downloading to python-3.12.8-amd64.exe - https://www.python.org/ftp/python/3.12.8/python-3.12.8-amd64.exe
MethodInvocationException: C:\Users\yen\Downloads\chocolatey-packages\automatic\python3-streams\update.ps1:42
Line |
  42 |    $response_stream = $webrequest.GetResponse().GetResponseStream()
     |    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | Exception calling "GetResponse" with "0" argument(s): "The remote server returned an error: (404) Not Found."

@robmoss2k
Copy link
Author

@yan12125 Thanks for picking that up - that's fixed now, and I also removed a logging statement I shouldn't have committed. I believe this is good to go now, and I've learned some useful things along the way 😄

@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants