-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(freecad): update release name regex #2578
base: master
Are you sure you want to change the base?
Conversation
✅ Package verification completed without issues. PR is now pending human review |
Does this need a 'Needs Review' label ? |
What's it going to take to get this merged? |
Match new names with v1: FreeCAD_1.0.0-conda-Windows-x86_64-installer-1.exe FreeCAD_1.0.0-conda-Windows-x86_64-py311.7z
✅ Package verification completed without issues. PR is now pending human review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per the PR template, please test the updated package in the Chocolatey test environment.
@@ -32,9 +32,8 @@ param( | |||
} | |||
'portable' { | |||
$download_page = (Get-GitHubRelease -Owner "Freecad" -Name "Freecad" -Verbose).assets | |||
$mobile = "portable" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per #2403 (comment)
@RedBaron2 suggested that the $mobile
variables be kept in use.
Description
Match new names with v1:
Motivation and Context
Missing update to v1.
How Has this Been Tested?
Regex tester.
Screenshot (if appropriate, usually isn't needed):
Types of changes
Checklist:
Original Location
Release v1:
https://github.com/FreeCAD/FreeCAD/releases/tag/1.0.0